Adding optional CUDA DLLs when installing onnxruntime_gpu #22506
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
There are some test failures, Please fix them. We will remove the "orttraining-linux-gpu-ci-pipeline". The others still need to be taking care of. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
setup.py
Outdated
| if cuda_version: | ||
| f.write(f"cuda_version = '{cuda_version}'\n") | ||
| # cudart_versions are integers | ||
| cudart_versions = find_cudart_versions(build_env=True) |
There was a problem hiding this comment.
find_cudart_versions only works on Linux. I think we can add a check of linux before calling find_cudart_versions to avoid a warning message in Windows.
|
|
||
|
|
||
| # Load nvidia libraries from site-packages/nvidia if the package is onnxruntime-gpu | ||
| if cuda_version is not None and cuda_version != "": |
There was a problem hiding this comment.
In my test, cuda_version is still empty string. It is imported from onnxruntime.capi.onnxruntime_validation in line 73. That class only outputs cuda_version for training as below:
onnxruntime/onnxruntime/python/onnxruntime_validation.py
Lines 100 to 102 in 29bccad
We can remove the line of
if has_ortmodule there.
|
|
||
| try: # noqa: SIM105 | ||
| from .build_and_package_info import cuda_version | ||
| except Exception: |
Check notice
Code scanning / CodeQL
Empty except Note
Description
This code change enable user to install Nvidia CUDA DLLs when installing onnxruntime_gpu. with
pip install onnxruntime_gpu[cuda_dlls].It will also enable onnxruntime_gpu to use dynamic libraries under site-packages/nvidia that contain .dll files for Windows and .so files for Linux by temporary updating the environmental variables within an ORT Inferencing session.
Motivation and Context
Request by